jchristn/WatsonWebsocket

TestSslClient and TestSslServer don't exist

Closed this issue · 4 comments

The readme makes mention of a TestSslClient and TestSslServer but these don't seem to exist in the project. There is also reference to test-certificate.txt but it looks like that was removed on Jun 12 with commit 44e8ace. Is the readme incorrect or were the files removed by accident?

Hi @FodderMK thanks for pointing that out. The test projects were collapsed into TestClient and TestServer, both of which prompt for whether or not SSL should be enabled. It appears I did (accidentally) remove the test SSL certificate. I'll make these adjustments and get a commit in right away.

In the meantime please feel free to use the test certificate from WatsonTcp, found here: https://github.com/jchristn/WatsonTcp/tree/master/TestClient

The .txt file should have the passwords, etc.

Thanks again for pointing this out! Will close once I update the README and get the certs back into the projects.

Actually I recall why I removed them. It's unnecessary. WatsonWebsocket uses HTTPS which relies on the certificate store provided by the operating system. You should only have to enable SSL by setting the bool in the constructor accordingly, and have the certificates loaded into the client and server certificate store. I'm adding the test certificate into the project so you can use it for this purpose though anyway.

I'm updating the README currently; closing this issue now.

Thanks!

Confirmed the presence of the test cert which can be loaded into the OS: https://github.com/jchristn/WatsonWebsocket/tree/master/TestClient

README is updated

Thanks!