Getting Error While Disconnecting a Client

Question

Getting Error While Disconnecting a Client

Closed this issue 4 years ago · 8 comments

Hi,

We are getting errors very frequently while disconnecting the client. Here is the complete stack trace. Please help -

Application: XXXXXXXXXX
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Net.HttpListenerException
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
at System.Net.WebSockets.WebSocketHttpListenerDuplexStream+d__30.MoveNext()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(System.Threading.Tasks.Task)
at System.Net.WebSockets.WebSocketBase+WebSocketOperation+d__19.MoveNext()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(System.Threading.Tasks.Task)
at System.Net.WebSockets.WebSocketBase+d__56.MoveNext()

Exception Info: System.Net.WebSockets.WebSocketException
at System.Net.WebSockets.WebSocketBase.ThrowIfConvertibleException(System.String, System.Exception, System.Threading.CancellationToken, Boolean)
at System.Net.WebSockets.WebSocketBase+d__56.MoveNext()

Exception Info: System.AggregateException
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean)
at System.Threading.Tasks.Task.Wait(Int32, System.Threading.CancellationToken)
at WatsonWebsocket.WatsonWsServer.DisconnectClient(System.String)
at _19_neostox_msgbroadcaster.Program+d__7.MoveNext()
at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.b__6_1(System.Object)
at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(System.Object)
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

Thanks and regards,
Rajesh

Answer 1 · 2020-12-07T18:12:23.000Z

Hi @rajeshdua123 please re-open if this does not fix the issue. Thanks for filing it!

NuGet v2.2.0.10: https://www.nuget.org/packages/WatsonWebsocket/2.2.0.10
Commit: c84681c

Answer 2 · 2020-12-07T18:51:39.000Z

Thanks @jchristn.

We have recently beta launched our product and currently, 5000-5500 concurrent connections are being managed through your WebSocket program and it's a breeze.

Will share more details once we go live with all the features. Infact, if you would allow, would write best practices as to how to make the best use of WatsonWeb Socket.

Answer 3 · 2020-12-07T19:51:26.000Z

Hi @rajeshdua123 that is awesome! I would love to have you and your team contribute best practices, wiki articles, anything that you think would give insight and guidance to others that are or want to use the library.

Also, if there are any capabilities that you feel would make the library better, please let me know! Cheers, Joel

Answer 4 · 2020-12-07T20:06:57.000Z

Will do it for sure.

Answer 5 · 2020-12-11T10:44:22.000Z

Hi Joel, Wanted to confirm you that after the updated release, all problems are fixed now. The entire system is running smoothly. Will be writing an article this weekend. One quick thing, I was trying to see the number of clients connected to the socket. So I used this - IEnumerable<string> ClientCount = server.ListClients(); Console.WriteLine(ClientCount.Count()); I observed that when clients are connected, the number increases and at disconnection the number decreases. Surprisingly, the total number of clients is more than the registered client number. Request you to please look into this and let me know if I have to do anything differently. Thanks and regards, Rajesh Dua

…

On Tue, Dec 8, 2020 at 1:21 AM Joel Christner ***@***.***> wrote: Hi @rajeshdua123 <https://github.com/rajeshdua123> that is *awesome*! I would love to have you and your team contribute best practices, wiki articles, anything that you think would give insight and guidance to others that are or want to use the library. Also, if there are any capabilities that you feel would make the library better, please let me know! Cheers, Joel — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#51 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL3TWQQAFP3QPT7HT3CGDPDSTUW43ANCNFSM4UQTTHLA> .

-- Thanks and regards, Rajesh Dua Mob: +91 9205727258

Answer 6 · 2020-12-13T00:26:25.000Z

Hi @rajeshdua123 thanks for your note. I'm having difficulty reproducing this last one. Do you have a high rate of connects and disconnects? If so it could be that, since the IEnumerable is taken from a ConcurrentDictionary, that there were updates since the call to the ListClients() call vs new connects/disconnects that occurred. Let me know. Thanks!

Answer 7 · 2020-12-16T16:39:01.000Z

Hi Joel, I have a program that is serving the clients. It is a bit complex mechanism. I need your help as to how to make it efficient. This program is consuming 10% of CPU. Please let me know the cost. Thanks and regards, Rajesh

…

On Sun, Dec 13, 2020 at 5:56 AM Joel Christner ***@***.***> wrote: Hi @rajeshdua123 <https://github.com/rajeshdua123> thanks for your note. I'm having difficulty reproducing this last one. Do you have a high rate of connects and disconnects? If so it could be that, since the IEnumerable is taken from a ConcurrentDictionary, that there were updates since the call to the ListClients() call vs new connects/disconnects that occurred. Let me know. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#51 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL3TWQUMB4B5GRBUHG44223SUQC35ANCNFSM4UQTTHLA> .

-- Thanks and regards, Rajesh Dua Mob: +91 9205727258

Answer 8 · 2020-12-16T16:55:48.000Z

Hi @rajeshdua123 do you have ANTS Performance Profiler? That may be the best place to start to see where in the code there is latency/CPU. If there are optimizations that would be beneficial in the library, I'd be more than happy to implement them. Feel free to email me at joel dot christner at gmail.