Use the cancelation token
Closed this issue · 4 comments
MeTitus commented
Just wondering why you're not using the if expression bellow in the actual while?
if (cancelToken.IsCancellationRequested) break;
jchristn commented
Great point, that could certainly be changed :) want to submit a PR?
MeTitus commented
The code needs a lot of fixing my friend, this is just one that I spotted today. Great work in getting it all together but it needs to go over a big deal of refactoring. Also, #region and all those comments are not really a thing.
jchristn commented
Yeah, I mainly use regions just to give myself an easy way to collapse small and large sections, primarily to allow me to focus. Happy to take a PR with your improvements!
jchristn commented
NuGet: https://www.nuget.org/packages/WatsonWebsocket/2.3.5
Commit: 3b51689
Thank you!