jdillard/sphinx-sitemap

Error with Sphinx 7.2

Closed this issue · 6 comments

kai687 commented

app.outdir is now a Path, not a string,
so line 213 breaks.

Opened #70, hopefully it works 🤞

Thanks! I'll have to test it out to make sure it doesn't break for older versions (it doesn't seem to be) and update tox as well now that 7 is out.

I'll have to test it out to make sure it doesn't break for older versions (it doesn't seem to be) and update tox as well now that 7 is out.

Want me to add that parametrization to continuous_integration.yml? Then you don't have to manually test this...

... couldn't resist the temptation. Added to #70 but I can revert if needed

Thanks for pointing that out @kai687 and thanks for the great work in the PR @larsoner!

2.5.1 is out now with the fix: https://github.com/jdillard/sphinx-sitemap/releases/tag/v2.5.1