jdinhify/vscode-theme-gruvbox

Inlay hints show odd colour

wchresta opened this issue · 1 comments

In rust, some extensions like rust-analyzer make significant use of the inlay-hints feature of vscode.

Apparently, vscode-theme-gruvbox does not correctly theme these and they appear with a magenta background:

screnshot

See also https://www.reddit.com/r/rust/comments/uki3xp/changing_inlay_hint_color_in_vscode/

I would expect the inlay hints to be less intrusive

VsCode:

Version: 1.69.2
Commit: 3b889b090b5ad5793f524b5d1d39fda662b96a2a
Date: 2022-07-18T16:14:10.636Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Linux x64 6.0.7

Theme:

v.1.8.0
Released on 9/25/2017, 03:22:21
Last updated 9/16/2022, 07:05:25
Identifier jdinhlife.gruvbox

you can manually change inlay hints colour in settings.json with following:

    "workbench.colorCustomizations": {
        "[Gruvbox Dark Hard]": {
            "editorInlayHint.foreground": "#938473",
            "editorInlayHint.background": "#00000036",

        },
        "[Gruvbox Dark Medium]": {
            "editorInlayHint.foreground": "#938473",
            "editorInlayHint.background": "#00000036",
        },
        "[Gruvbox Dark Soft]": {
            "editorInlayHint.foreground": "#938473",
            "editorInlayHint.background": "#00000036",
        }
    },

it would look like this
изображение

it binds absolute colour for chosen theme, not already existing colour in theme, so you can pick any colour for hints you like (but secretely i want gruvbox theme to make them less intrusive on its own too)