jdorn/sql-formatter

[NFR] Uppercase keywords

quasipickle opened this issue · 8 comments

quasipickle commented

I have patched my local copy to automatically uppercase any reserved keywords. So a submitted query like:

select * from blah as b

Gets formatted into

SELECT
  *
FROM
  blah AS b

Is there any interest in me making a full pull request of this functionality?

morphiaz commented

👍

SmetDenis commented

Cool!

quasipickle commented

Until I hear back from @jdorn, here's my changes:

Line 144:

public static $uppercase = true;

Line 692:

if(self::$uppercase && in_array($token[self::TOKEN_TYPE],array(self::TOKEN_TYPE_RESERVED,self::TOKEN_TYPE_RESERVED_NEWLINE,self::TOKEN_TYPE_RESERVED_TOPLEVEL))){
   $highlighted = strtoupper($highlighted);
}
jdorn commented

That looks fine if you want to create a pull request. Just make sure self::$uppercase defaults to false to keep it backwards compatible.

quasipickle commented

Request made: #86

zobzn commented

👍 awesome

acicali commented

Just wanted to add my 2 cents here...

Why not just add CSS classes instead of inline styles? Then not only could this be accomplished in CSS, but changing colors could be done easily without modifying the codebase. I'd also like to add backticks to the queries... classes would solve that as well.