jdsdev/Embedder

PHP 5.4 required

aelvan opened this issue · 1 comments

Hi,

Great plugin, I was about to start making the exact same thing myself, and then noticed this. Thanks! :)

One minor thing, the use of the "array shorthand notation" on the default values in EmbedderVariable ("params = []"), makes the plugin require PHP 5.4. I find this a bit unnecessary, using "params = array()" instead fixes this, and I think the result is the same?

A-P commented

Good catch, thanks @aelvan. It's been a long time since I've done anything with PHP < 5.4, but since Craft supports it, I guess I should as well :)