Doesn't destroy and rebuild properly
BennyCarlsson opened this issue · 5 comments
On unmount the slider doesn't get destroyed proberly.
I have a component using the slider.
It get images as props.
When the image props changes the component rerender. The slider tries to destroy() and rebuild() however slider state is not properly destroyed and the slider ends up with old and new images.
Will try to extract the component to show of a minimum example.
Created minimum project to reproduce the bug
https://codesandbox.io/s/tiny-slider-bug-qji0w
Try
On unmount the slider doesn't get destroyed proberly.
I have a component using the slider.
It get images as props.
When the image props changes the component rerender. The slider tries to destroy() and rebuild() however slider state is not properly destroyed and the slider ends up with old and new images.Will try to extract the component to show of a minimum example.
Hello try to use this package is a fork
https://github.com/ferblacklion/tiny-slider-react
fixed v0.5.2
v0.5.3 - issue reproduced.
Yep, still the same.