jednano/codepainter

infer does not take ReadableStreams as input

Closed this issue · 7 comments

According to the 'Library Usage' section of the README, it should be possible to pass an instance of ReadableStream to codepainter.infer. However, doing this results in a type error:

path.js:313
        throw new TypeError('Arguments to path.resolve must be strings');
              ^
TypeError: Arguments to path.resolve must be strings
    at Object.exports.resolve (path.js:313:15)

The problem seems to be this line in MultiInferrer.onGlobPath:

var editorConfigStyle = editorconfig.parse(path);

Commenting out that line and the following conditional works.

Hi. Thanks for filing this. What is your environment?

node version is v0.10.21. Any other environment info that would be helpful?

Yes. What shell are you using and on what OS?

Hey Jed-- I'm trying to call codepainter programmatically, so I'm not sure the shell is relevant. I'm on OS X 10.9.

Thanks. Let me try to make some time to look into this.

Resolved in commit 2603254

I also wrote a test to cover this scenario.

Thanks for the fix!