jeerbl/webfonts-loader

writeFiles should default to false

andersk opened this issue · 2 comments

andersk commented

Commit be4fef9 changed the writeFiles default to true. This creates extra unused copies of the CSS and font files in the current directory, in addition to the normal Webpack output chain. A Webpack loader shouldn’t have extra side effects like that.

jeerbl commented

@andersk you're actually completely right. This change to use webfonts-generator default value was a mistake. Pull request to revert it? Actually, even having the writeFiles option in this webpack loader doesn't make sense. It should be false all the time.

  • 👍1
jeerbl commented

I have to make a major version for this since it's a breaking change. Here comes v7