jeevatkm/ReplyWithHeaderMozilla

When replying to message threads, a new line is not inserted

vincejv opened this issue · 13 comments

When this addon is active, when replying to message threads, a new line is not inserted, however when starting a new email from scratch a new line is inserted.
Might be related to #75, I think new Thunderbird versions compensate for the bug mentioned in #75, my suggestion is to have a setting for this or to detect the thunderbird version.

See the screenshot below with Thunderbird 102.1.2

New Email:

image

Reply/Forward:

image

I confirm that a new line is missing at the beginning of the reply. However, this issue is slightly broader. If using plain text signatures, Thunderbird uses a specific format and style (namely "Preformat") for the signature. When I then add a new line manually, the new line inherits the text style from the signature which is different from a default text style.

image

I'm seeing similar symptoms.

This happens to me after TB update from 91.x to 102.x (using German version 102.3.1 at the moment)

BUT it only happens on forwarding emails.
When using "Reply" or "Reply to all", everything is OK.

jpl75 commented

I have the issue on reply also.

Some more details on the issue.

My Thunderbird settings :

  • Automaticaly quote the original message when replying : checked
    - and place my signature below my reply (above the quote)
    - Include signature for replies : checked
    - Include signature for forward : checked

When I reply to a mail without ReplyWithHeader, the beginning of the mail is :

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-signature">

When I reply to a mail with ReplyWithHeader, the beginning of the mail is :

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=">
  </head>
  <body>
    <div class="moz-signature">

So apparenly the line above the signature is removed by ReplyWithHeader. Note : I made the test with all other extensions removed.

Thanks in advance for the resolution.

Same problem here, on all cases (reply / forward).

jpl75 commented

When this addon is active, when replying to message threads, a new line is not inserted, however when starting a new email from scratch a new line is inserted. Might be related to #75, I think new Thunderbird versions compensate for the bug mentioned in #75, my suggestion is to have a setting for this or to detect the thunderbird version.

I tried to undo the changes done for #75. It corrected the issue for replies, not for forward.

Same issue. RWH appears to change the way Reply works with a Signature. With RWH 2.5 installed and Tbird 102.12.0, Write a message works just fine, showing my simple signature and a blank line above the signature in Paragraph style. Reply to a message now works differently after installing RWH. There is no blank line in Paragraph style above my signature. It is simple enough to enter a return and change the style to Paragraph but I would think RWH should not change the base function of Reply. Please advise, thank you.

Here are pictures to go with the above. Note the first is taken from Write a message; the second is taken from Reply To All. The first has a blank line and Style of Paragraph; the second has no blank line and Style is Preformat.

image

Thanks for the discussion. Handling signature part is gets tricky. I will try to reproduce and fix, when I need help I will reach out here.

@vincejv I have created a v2.7.0-beta build; please try it out and share feedback.
https://docs.myjeeva.com/rwh-mozilla/replywithheader-v2.7.0-beta.xpi

I have retested the issue on Thunderbird 115.3.1 (64-bit) with v2.7.0-beta.
The issue still remains. There is a missing newline when replying and using signatures at the same time.

Thunderbird settings -> Composition -> HTML Style
Uncheck "Use Paragraph format instead of Body Text by default"

@Unambiguous newline issue sorted out screenshots for you to take a look at.

Reply
Screenshot 2023-10-11 at 7 44 05 PM

Forward
Screenshot 2023-10-11 at 7 44 53 PM

I confirm that the newline works correctly now. It works regardless on the settings mentioned in #121 (comment).
It seems that I had to restart Thunderbird a few times in order for the changes to take effect.

Thank you, @jeevatkm.