jeffersonRibeiro/react-shopping-cart

redundant mapStateToProps in Filter component

saher-elgendy opened this issue · 2 comments

saher-elgendy commented

I think this part is redundant as you did not use filters props in the component

const mapStateToProps = state => ({
  filters: state.filters.items
});

export default connect(
  mapStateToProps,
  { updateFilters }
)(Filter);

I think the first argument of connect should be null, or you may have an explanation for this!!

jeffersonRibeiro commented

Hi @saher-elgendy ! Thank you for pointing that out, when I got time I will fix.

If you wish to send a PR I will kindly accept.

syedsaadqamar commented

PR #23 credit goes to @saher-elgendy