jefflai108/Contrastive-Predictive-Coding-PyTorch

NCE accuracy calculation

JaejinCho opened this issue · 1 comments

JaejinCho commented

Hello @jefflai108,

I think the accuracy also should have its denominator as batch*self.timestep at

Contrastive-Predictive-Coding-PyTorch/src/model/model.py

Line 320 in a9dab4e

accuracy = 1.*correct.item()/batch

Possibly for other models too although I did not check them.

colinator commented

Yes, and it should be correct += I believe, just above there...