Miscellaneous Functionality Cleanup
Closed this issue · 1 comments
jefflester commented
A few things could be touched up in Minitrino:
- Instead of using bootstrap scripts for
config.properties
management, we could use a more user-friendly approach involving environment variables defined in the Compose YAML. Something like:
trino:
environment:
CONFIG_PROPERTIES: |-
insights.jdbc.url=jdbc:postgresql://postgres-query-logger:5432/querylogger
insights.jdbc.user=admin
insights.jdbc.password=trinoRocks15
insights.persistence-enabled=true
insights.metrics-persistence-enabled=true
We'd merge these together based on the presence of configured properties in whatever modules the user wants to provision, then either run an automated script inside the Trino container or mount the collection of properties as a cohesive config.properties
file to the container.
We'd want to keep the existing bootstrap functionality around while simultaneously decoupling it from managing this config file.
- Remove CLI support for
CONFIG
andJVM_CONFIG
environment variables (see: readme). This is messy and buggy in the first place, and by implementing the 1st request above, there would be little to no need to support these variables.
jefflester commented
Closed with #56