jefflester/minitrino

Factor in stale testing library when upgrading main package via Pip

Closed this issue · 1 comments

Here is a use case not previously considered:

  • User installs dev build with install.sh
  • At a later point, the user attempts to upgrade Minitrino with Pip - pip install minitrino --upgrade
  • Because the dev build installs the testing library, but the testing library is not uploaded to PyPI as part of the package, the user is subject to seeing dependency mismatch errors like this:
minitrino-tests 0.0 requires requests==2.31.0, but you have requests 2.32.0 which is incompatible.

The install should either (1) display a user-friendly message explaining how to triage the issue or (2) factor this into the overall install and clean up the mismatches at runtime.

Now that I think about this more, I'm going to close this. Moving forward, the testing library and the CLI should have the same requests dependency.