highlights_on: false doesn't work

[fantgeass]

I set "highlights_on: false" to the item, but LI-tag still have class 'active' when I'm on that page.

[jejacks0n]

Does it work with nil?, or an empty array?

[fantgeass]

nope

[gucki]

I think the problem is that you always add the link to the list:

navigasmic/lib/navigasmic/core/item.rb

Line 52 in f62ae17

def calculate_highlighting_rules(rules)

I'd prefer to only add the link as a default, so when no :highlights_on argument is given. This is in incompatible change, but imo the only way to make :hightlights_on => false - and other cases where you don't want the item be highlighted when visiting the link it points to - work. What do you think?

[jejacks0n]

Looks like this is fixed.. please report your findings.