Deprecate magic train untrain methods
ibnesayeed opened this issue · 10 comments
Before releasing 2.2.0 magical train_* and untrain_* style methods should be deprecated.
- Add deprecation warning
- Add tests to not use these methods
- Update documentation to not use these methods
It would also be good to have the official development Docker image available (#101) before the release of 2.2.0 so that it can be documented and advertised with this rather significant release.
Perhaps we can also include basic validation #71 as part of 2.2.0 release.
Sounds good. I have a working branch for the first two items. I'll push it up later.
I can take care of the documentation, later tonight.
PR #141 takes care of the documentation.
@Ch4s3 a note for you. I have seen test_external_classifying of lsi_test.rb using magic methods. Just make sure to take care of all the places where Bayes is being called with magic methods.
Yeah, that's on the list. I'll try to devote some time to this tomorrow or Monday.
I'll try to get back to this asap
@ibnesayeed will do.