jekyll/jekyll-gist

special character in file name

jungbin-kim opened this issue · 2 comments

In my case, gist file extension is ".scala".
So, I write below in my post.
{% gist jungbin-kim/acc54d54af4ff954105338534636526a Kakao-coding-test-#1.scala %}
However, it generates
https://gist.github.com/jungbin-kim/acc54d54af4ff954105338534636526a.js?file=Kakao-coding-test-
I think it miss special character like '#'

I expect like below
https://gist.github.com/jungbin-kim/acc54d54af4ff954105338534636526a?file=Kakao-coding-test-#1.scala

It might be involved at this line.

url = "https://gist.github.com/#{gist_id}.js"

Thank you

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

It looks like GitHub just strips octothorps when creating ids. I guess we should strip them as well when creating the URL.