Failing tests
utkarsh2102 opened this issue · 2 comments
utkarsh2102 commented
Hi,
Some tests seem to be failing,
Here are the logs:
All examples were filtered out; ignoring {:focus=>true}
Randomized with seed 5559
Jekyll::Gist::GistTag
invalid gist
no gist id present
Liquid Exception: Syntax error in tag 'gist' while parsing the following markup: Valid syntax: {% gist user/1234567 %} {% gist user/1234567 foo.js %} {% gist 28949e1d5ee2273f9fd3 %} {% gist 28949e1d5ee2273f9fd3 best.md %} in /home/utkarsh2102/debian/updates/gist/ruby-jekyll-gist/tmp/source/_test/doc.md
WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives, since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<ArgumentError: Syntax error in tag 'gist' while parsing the following markup:
Valid synt.../1234567 foo.js %}
{% gist 28949e1d5ee2273f9fd3 %}
{% gist 28949e1d5ee2273f9fd3 best.md %}
>. Instead consider providing a specific error class or message. This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`. Called from /home/utkarsh2102/debian/updates/gist/ruby-jekyll-gist/spec/gist_tag_spec.rb:171:in `block (4 levels) in <top (required)>'.
raises an error
valid gist
with noscript disabled
does not produce the noscript tag
with valid gist id and invalid filename
produces the correct script tag
does not produce the noscript tag
classic Gist id style
produces the correct noscript tag (FAILED - 1)
produces the correct script tag
with file specified
produces the correct noscript tag (FAILED - 2)
produces the correct script tag
with variable gist id
produces the correct script tag (FAILED - 3)
produces the correct noscript tag (FAILED - 4)
with token
produces the noscript tag (FAILED - 5)
with a filename
produces the noscript tag (FAILED - 6)
with user prefix
produces the correct noscript tag (FAILED - 7)
produces the correct script tag
without user prefix
produces the correct noscript tag (FAILED - 8)
produces the correct script tag
with variable gist id and filename
produces the correct noscript tag (FAILED - 9)
produces the correct script tag (FAILED - 10)
Failures:
1) Jekyll::Gist::GistTag valid gist classic Gist id style produces the correct noscript tag
Failure/Error: expect(output).to match(%r!<noscript><pre><test>true<\/test><\/pre><\/noscript>\n!)
expected "<script src=\"https://gist.github.com/1234321.js\"> </script>\n\n" to match /<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
Diff:
@@ -1,2 +1,2 @@
-/<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
+<script src="https://gist.github.com/1234321.js"> </script>
# ./spec/gist_tag_spec.rb:47:in `block (4 levels) in <top (required)>'
2) Jekyll::Gist::GistTag valid gist with file specified produces the correct noscript tag
Failure/Error: expect(output).to match(%r!<noscript><pre><test>true<\/test><\/pre><\/noscript>\n!)
expected "<script src=\"https://gist.github.com/mattr-/24081a1d93d2898ecf0f.js?file=myfile.ext\"> </script>\n\n" to match /<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
Diff:
@@ -1,2 +1,2 @@
-/<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
+<script src="https://gist.github.com/mattr-/24081a1d93d2898ecf0f.js?file=myfile.ext"> </script>
# ./spec/gist_tag_spec.rb:61:in `block (4 levels) in <top (required)>'
3) Jekyll::Gist::GistTag valid gist with variable gist id produces the correct script tag
Failure/Error: expect(output).to match(%r!<script src="https:\/\/gist.github.com\/#{doc.data['gist_id']}.js">\s<\/script>!)
expected "<script src=\"https://gist.github.com/page.gist_id.js\"> </script>\n\n" to match /<script src="https:\/\/gist.github.com\/1342013.js">\s<\/script>/
Diff:
@@ -1,2 +1,2 @@
-/<script src="https:\/\/gist.github.com\/1342013.js">\s<\/script>/
+<script src="https://gist.github.com/page.gist_id.js"> </script>
# ./spec/gist_tag_spec.rb:76:in `block (4 levels) in <top (required)>'
4) Jekyll::Gist::GistTag valid gist with variable gist id produces the correct noscript tag
Failure/Error: expect(output).to match(%r!<noscript><pre><test>true<\/test><\/pre><\/noscript>\n!)
expected "<script src=\"https://gist.github.com/page.gist_id.js\"> </script>\n\n" to match /<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
Diff:
@@ -1,2 +1,2 @@
-/<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
+<script src="https://gist.github.com/page.gist_id.js"> </script>
# ./spec/gist_tag_spec.rb:79:in `block (4 levels) in <top (required)>'
5) Jekyll::Gist::GistTag valid gist with token produces the noscript tag
Failure/Error: expect(output).to match(%r!<noscript><pre>contents of gist<\/pre><\/noscript>!)
expected "<script src=\"https://gist.github.com/page.gist_id.js\"> </script>\n\n" to match /<noscript><pre>contents of gist<\/pre><\/noscript>/
Diff:
@@ -1,2 +1,2 @@
-/<noscript><pre>contents of gist<\/pre><\/noscript>/
+<script src="https://gist.github.com/page.gist_id.js"> </script>
# ./spec/gist_tag_spec.rb:136:in `block (4 levels) in <top (required)>'
6) Jekyll::Gist::GistTag valid gist with token with a filename produces the noscript tag
Failure/Error: expect(output).to match(%r!<noscript><pre>puts 'hello world'<\/pre><\/noscript>!)
expected "<script src=\"https://gist.github.com/1342013.js?file=hello-world.rb\"> </script>\n\n" to match /<noscript><pre>puts 'hello world'<\/pre><\/noscript>/
Diff:
@@ -1,2 +1,2 @@
-/<noscript><pre>puts 'hello world'<\/pre><\/noscript>/
+<script src="https://gist.github.com/1342013.js?file=hello-world.rb"> </script>
# ./spec/gist_tag_spec.rb:147:in `block (5 levels) in <top (required)>'
7) Jekyll::Gist::GistTag valid gist with user prefix produces the correct noscript tag
Failure/Error: expect(output).to match(%r!<noscript><pre><test>true<\/test><\/pre><\/noscript>\n!)
expected "<script src=\"https://gist.github.com/mattr-/24081a1d93d2898ecf0f.js\"> </script>\n\n" to match /<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
Diff:
@@ -1,2 +1,2 @@
-/<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
+<script src="https://gist.github.com/mattr-/24081a1d93d2898ecf0f.js"> </script>
# ./spec/gist_tag_spec.rb:23:in `block (4 levels) in <top (required)>'
8) Jekyll::Gist::GistTag valid gist without user prefix produces the correct noscript tag
Failure/Error: expect(output).to match(%r!<noscript><pre><test>true<\/test><\/pre><\/noscript>\n!)
expected "<script src=\"https://gist.github.com/28949e1d5ee2273f9fd3.js\"> </script>\n\n" to match /<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
Diff:
@@ -1,2 +1,2 @@
-/<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
+<script src="https://gist.github.com/28949e1d5ee2273f9fd3.js"> </script>
# ./spec/gist_tag_spec.rb:35:in `block (4 levels) in <top (required)>'
9) Jekyll::Gist::GistTag valid gist with variable gist id and filename produces the correct noscript tag
Failure/Error: expect(output).to match(%r!<noscript><pre><test>true<\/test><\/pre><\/noscript>\n!)
expected "<script src=\"https://gist.github.com/page.gist_id.js?file=page.gist_filename\"> </script>\n\n" to match /<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
Diff:
@@ -1,2 +1,2 @@
-/<noscript><pre><test>true<\/test><\/pre><\/noscript>\n/
+<script src="https://gist.github.com/page.gist_id.js?file=page.gist_filename"> </script>
# ./spec/gist_tag_spec.rb:102:in `block (4 levels) in <top (required)>'
10) Jekyll::Gist::GistTag valid gist with variable gist id and filename produces the correct script tag
Failure/Error: expect(output).to match(%r!<script src="https:\/\/gist.github.com\/#{doc.data['gist_id']}.js\?file=#{doc.data['gist_filename']}">\s<\/script>!)
expected "<script src=\"https://gist.github.com/page.gist_id.js?file=page.gist_filename\"> </script>\n\n" to match /<script src="https:\/\/gist.github.com\/1342013.js\?file=atom.xml">\s<\/script>/
Diff:
@@ -1,2 +1,2 @@
-/<script src="https:\/\/gist.github.com\/1342013.js\?file=atom.xml">\s<\/script>/
+<script src="https://gist.github.com/page.gist_id.js?file=page.gist_filename"> </script>
# ./spec/gist_tag_spec.rb:98:in `block (4 levels) in <top (required)>'
Finished in 0.11652 seconds (files took 3.19 seconds to load)
18 examples, 10 failures
Failed examples:
rspec ./spec/gist_tag_spec.rb:46 # Jekyll::Gist::GistTag valid gist classic Gist id style produces the correct noscript tag
rspec ./spec/gist_tag_spec.rb:60 # Jekyll::Gist::GistTag valid gist with file specified produces the correct noscript tag
rspec ./spec/gist_tag_spec.rb:75 # Jekyll::Gist::GistTag valid gist with variable gist id produces the correct script tag
rspec ./spec/gist_tag_spec.rb:78 # Jekyll::Gist::GistTag valid gist with variable gist id produces the correct noscript tag
rspec ./spec/gist_tag_spec.rb:135 # Jekyll::Gist::GistTag valid gist with token produces the noscript tag
rspec ./spec/gist_tag_spec.rb:146 # Jekyll::Gist::GistTag valid gist with token with a filename produces the noscript tag
rspec ./spec/gist_tag_spec.rb:22 # Jekyll::Gist::GistTag valid gist with user prefix produces the correct noscript tag
rspec ./spec/gist_tag_spec.rb:34 # Jekyll::Gist::GistTag valid gist without user prefix produces the correct noscript tag
rspec ./spec/gist_tag_spec.rb:101 # Jekyll::Gist::GistTag valid gist with variable gist id and filename produces the correct noscript tag
rspec ./spec/gist_tag_spec.rb:97 # Jekyll::Gist::GistTag valid gist with variable gist id and filename produces the correct script tag
Randomized with seed 5559
/usr/bin/ruby2.5 /usr/bin/rspec --pattern ./spec/\*\*/\*_spec.rb --format documentation failed
ERROR: Test "ruby2.5" failed. Exiting.
ashmaroli commented
@utkarsh2102 How were the tests run?
The steps should either be:
bundle update && bundle exec rspec
or
bundle update && bash script/cibuild
I ran a build on Travis CI with our latest master. Except for a warning from RSpec, the tests pass successfully:
https://travis-ci.org/jekyll/jekyll-gist/builds/484637483
jekyllbot commented
This issue has been automatically marked as stale because it has not been commented on for at least two months.
The resources of the Jekyll team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.
This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.