Code font-size too small in Minima 3
travisdowns opened this issue · 1 comments
I recently upgraded from Minima 2.5.1 to 3 (i.e,. the current head of master).
After building, I noticed that all the code samples on my blog had a too-small font size compared to before, significantly smaller than the surrounding text.
See the example below:
| Minima 2.5.1 | Minima 3.x |
|---|---|
 |
 |
The line-height looks the same in both cases, so there is a lot of empty space in the 3.0 version, but this isn't really about that.
The cause is #435 which switched from using a fixed 15px font to 0.9375 em. Since the base size is 16px, 16 * 0.9375 = 15 so the size should be the same as before, right?
The problem is this style applies both to <code> and <pre> tags, and code samples use both tags, with <code> nested within <pre>:
So the * .9375 gets applied twice and you end up with about a 14px font.
One solution would be to just apply the smaller size to <code>: it's not clear why <pre> should get this treatment? There is probably some more advanced CSS solution too to avoid problems with nesting, but that's not my area of expertise.
This issue has been automatically marked as stale because it has not been commented on for at least two months.
The resources of the Jekyll team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.
This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.