SASS moving to math.div and Minima is using deprecated division
BillRaymond opened this issue · 1 comments
BillRaymond commented
When I run bundle exec jekyll build --verbose, I receive the following warnings. There are several areas in the Minima theme's SASS files where math.div should be used instead of a / (divided by slash).
Here is the portion of my verbose output that displays the warnings:
Rendering Markup: assets/main.scss
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacing-unit, 2) or calc($spacing-unit / 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
40 │ margin-bottom: $spacing-unit / 2;
│ ^^^^^^^^^^^^^^^^^
╵
/workspaces/agile-in-action-minima/_sass/minima/_base.scss 40:18 @import
minima.scss 49:3 @import
/workspaces/agile-in-action-minima/assets/main.scss 1:9 root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacing-unit, 2) or calc($spacing-unit / 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
134 │ padding-left: $spacing-unit / 2;
│ ^^^^^^^^^^^^^^^^^
╵
/workspaces/agile-in-action-minima/_sass/minima/_base.scss 134:17 @import
minima.scss 49:3 @import
/workspaces/agile-in-action-minima/assets/main.scss 1:9 root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacing-unit, 2) or calc($spacing-unit / 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
189 │ padding-right: $spacing-unit / 2;
│ ^^^^^^^^^^^^^^^^^
╵
/workspaces/agile-in-action-minima/_sass/minima/_base.scss 189:20 @content
minima.scss 38:5 media-query()
/workspaces/agile-in-action-minima/_sass/minima/_base.scss 186:3 @import
minima.scss 49:3 @import
/workspaces/agile-in-action-minima/assets/main.scss 1:9 root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacing-unit, 2) or calc($spacing-unit / 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
190 │ padding-left: $spacing-unit / 2;
│ ^^^^^^^^^^^^^^^^^
╵
/workspaces/agile-in-action-minima/_sass/minima/_base.scss 190:19 @content
minima.scss 38:5 media-query()
/workspaces/agile-in-action-minima/_sass/minima/_base.scss 186:3 @import
minima.scss 49:3 @import
/workspaces/agile-in-action-minima/assets/main.scss 1:9 root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacing-unit, 3) or calc($spacing-unit / 3)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
244 │ padding: ($spacing-unit / 3) ($spacing-unit / 2);
│ ^^^^^^^^^^^^^^^^^
╵
/workspaces/agile-in-action-minima/_sass/minima/_base.scss 244:15 @import
minima.scss 49:3 @import
/workspaces/agile-in-action-minima/assets/main.scss 1:9 root stylesheet
Warning: 6 repetitive deprecation warnings omitted.
Run in verbose mode to see all warnings.
ashmaroli commented
@BillRaymond Does math.div work on older stylesheets? If yes, feel free to submit a pull request for this.