Merge results - function arguments as input parameters

Question

Merge results - function arguments as input parameters

Closed this issue 5 years ago · 4 comments

The function mergeResults takes arguments as input which are not used by it.
It uses the process arguments - process.argv[2] and process.argv[3] to set the directory and file pattern.
This function is called from other scripts that could have different process arguments set and hence does not work for this case. Can mergeResults instead use the arguments sent to it to get the directory and file pattern?

Answer 1 · 2019-07-26T17:52:12.000Z

@fijijavis : Do you think this could be changed?

Answer 2 · 2019-07-26T17:56:10.000Z

@kmnaid yes. I thought there was an open PR but I can’t find it now???

Answer 3 · 2019-07-26T18:00:45.000Z

@fijijavis : Oh I see, I can create one.

Answer 4 · 2020-03-04T10:39:47.000Z

PR #42 resolves the issue