jenil/bulmaswatch

Using px in darkly theme should be discouraged

jondoe1337 opened this issue · 4 comments

jondoe1337 commented

Size is set to 15px. But this collides for example if you use bulma-switch where the variable is used with rem, which leads to:

Incompatible units: 'rem' and 'px'.
jenil commented

I think you might want to handle this with custom CSS since bulma-switch is anyways a plugin right?

jondoe1337 commented

This sounds more like a workaround to me. The thing is that the themes sometimes use rem and darkly px. And some do not even define any size.

jenil commented

I'm not sure if I understand this correctly then, can you make a codepen or point me to something? Darkly just updates the base variables and a few overrides to achieve the look

jondoe1337 commented

Sure:
https://github.com/jenil/bulmaswatch/blob/gh-pages/darkly/_variables.scss#L28
Uses px. If the size is used somewhere else with a relative setting using rem the sass compiler will crash.

Of course bulma-switch is a plugin, but I'd say that rem is more commonly used in the template context.

  • 👍1