double negative ish on health scrore

Question

double negative ish on health scrore

halkeye opened this issue a year ago · 2 comments

Problem with this page

https://plugins.jenkins.io/ldap/healthscore/

Expected behavior

No commit in the last 4 years. 0%

0 percent sounds bad. But it seems like from the above checks that there is comments newer than 4 years ago. So this feels like the check is inverted, if the only commits are more than 4 years ago, then negative points.

I think the check should be "had commits more recent than 4 years ago" so it sticks with convention

Or I'm wrong and it proves my point it's confusing

Actual behavior

Na

Possible solution

No response

Answer 1 · 2023-10-26T07:08:53.000Z

I think this issue should be on the plugin health scoring repo, that's where this bug comes from

https://github.com/jenkins-infra/plugin-health-scoring/blob/main/core/src/main/java/io/jenkins/pluginhealth/scoring/scores/AdoptionScoring.java#L186

Answer 2 · 2023-10-26T12:22:58.000Z

thanks for reporting this @halkeye (and @zbynek and @smerle33 for transferring the issue here).

Or I'm wrong and it proves my point it's confusing

You are not wrong but still it is confusing. Once we see that the gap between the latest release and the latest commit is less than 6 months, we shouldn't try to see if there is less than a year between the two. And so on.

There is a large problem in the AdoptionScoring implementation, which I think I resolved in #392.
I'll merge this and release the project so that we can get rid of this invalid information.