jenkins-x-plugins/jx-release-version

Support for Gradle

Closed this issue · 10 comments

Support Gradle with reading the version from either build.gradle or gradle.properties.

It is a simple property and should be easy to get, but it can be stored in either build.gradle or gradle.properties

version = 1.0

This tool worked on a gradle project, but only on master branch. For any release branch it output 0.0.1 if I used --same-release, and without --same-release I got an error:
failed to get new version strconv.ParseInt: parsing "51.2": invalid syntax

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

/remove-lifecycle stale

+1, building a project with Gradle 5 and the buildpack runs Gradle 4.6 instead of using the gradle wrapper and the version indicated therein. Should use ./gradlew

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

/remove-lifecycle stale

We have a PR #48 from @zachwhaley with Gradle Support.

Though the PR does not support Gradle version being stored in gradle.properties instead of the build.gradle file. Not sure how many who do store the version in the gradle.properties. I do it in some of my projects.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

/remove-lifecycle stale

Can anyone finally see to merge the PR #48?

FYI, this is supported in our fork https://github.com/trendmicro/new-release-version