Upgrade Jenkins X repositories to go 1.19
ankitm123 opened this issue · 40 comments
When we were upgrading the go version to 1.18, we noticed that we are limited by the version of go in the goreleaser image. We are now building a custom image where we can set the version of go and install other packages we need. Once that is done, we can start this update work.
Golang supports only 2 major releases: https://endoflife.date/go
The latest version of golang is 1.19.2
Follow this guide for information on how to upgrade: https://jenkins-x.io/community/maintainer_guide/go-upgrades/
Before upgrading , we need to upgrade the version of golang in the catalog repository:
example (there are other files as well): https://github.com/jenkins-x/jx3-pipeline-catalog/blob/0f0f956d38ffe383ba38d93c1cfe7160a3bec93a/tasks/go/pullrequest.yaml#L37
This is the tentative list of repositories (list will be updated if we find any missing repositories) that we should upgrade:
- jx-kubeclient - no other jx dependencies
- go-scm - no other jx dependencies
- logrus-stackdriver-formatter - no jx dependencies
- lighthouse
- go-scm
- jx-logging:
- logrus-stackdriver-formatter
- secretfacade
- jx-logging
- jx-api
- jx-logging
- jx-helpers
- github.com/jenkins-x/go-scm
- github.com/jenkins-x/jx-api
- github.com/jenkins-x/jx-kube-client
- github.com/jenkins-x/jx-logging
- jx
- jx-api
- jx-helpers
- jx-kube-client
- jx-logging
- jx-git-operator
- bdd-jx3
- jx-gitops
- jx-changelog
- jx-secret
- jx-admin
- jx-preview
- jx-promote
- jx-pipeline
- jx-updatebot
- jx-scm
- jx-registry
- jx-slack
- jx-release-version
- jx-verify
- jx-application
- jx-build-controller
- jx-test
In the list, there are some packages which need multiple packages updated before we update them, for example: before upgrading jx-api we should upgrade jx-logging.
NOTE: it's fine if you dont follow the order, the order is only there to limit the number of PRs we open as part of an upgrade effort
We will this issue to keep track of which repositories have been upgraded.
If you are interested in contributing, please comment
I want to upgrade <repo-name>
When opening a PR in these repos to upgrade the go version, remember to include
related to #<issue-number>
Dont use fixes as that will close this issue once ur PR is merged.
Once your PR is merged, comment in this issue:
<reponame> has been upgraded to 1.19.2
I want to upgrade jx-kubeclient
I want to upgrade go-scm
I want to upgrade jx-preview
go-scm Go version has been upgraded to 1,19.3 and it's golangci-lint to 1.50.1
I want to upgrade logrus-stackdriver-formatter
i want to upgrade jx-logging
I want to upgrade secretfacade
I want to upgrade jx-api
I want to upgrade jx-helpers
I want to upgrade jx-git-operator
I want to upgrade bdd-jx3
I want to upgrade jx-gitops
I want to upgrade jx-changelog
I want to upgrade jx-secret
I want to upgrade jx-admin
I want to upgrade jx-admin
Hey Pratik, try running test cases and building the repo, you might find other issues as well if possible solve them too.
jx-logging has been upgraded to 1.19.3
secretfacade has been upgraded to 1.19.3
jx-api has been upgraded to 1.19.3
jx-helpers has been upgraded to 1.19.3
bdd-jx3 has been upgraded to 1.19.3
jx-gitops has been upgraded to 1.19.3
jx-changelog has been upgraded to 1.19.3
I want to upgrade jx-admin
@SrutiMi try to upgrade from jx-promote and onwards... i have updated the jx-admin and it just need an approval to merge
I want to upgrade jx-pipeline.
I want to upgrade jx-updatebot
Hey @ankitm123 , this isuue is still open to work?
@ADITYADAS1999 check the list in the first post. the repos that are not marked need to be updated. Once a repo gets updated, a bot automatically updates the list.
@ADITYADAS1999 check the list in the first post. the repos that are not marked need to be updated. Once a repo gets updated, a bot automatically updates the list.
Thanks for the information @aahmed7
I want to upgrade jx-test
I want to upgrade jx-promote
I want to upgrade jx-pipeline
I want to upgrade jx-updatebot
jx-promote has been upgraded to 1.19.5
I want to upgrade jx-scm
I want to upgrade jx-slack