jeremybarbet/react-native-modalize

Iphone 14 modalTopOffset default is off

brianedelman opened this issue · 6 comments

brianedelman commented

Describe the bug
On iphone 14 (specifically tested on Pro) with iso 16.0 the modalTopOffset needs to be adjusted in a way that it doesn't need to be for other iphone models.

The same implementation produces these results on 13 vs 14. I can manually add modalOffset top to resolve the issue but I believe this should be handled by default.

Reproduce
Screen Shot 2022-09-14 at 12 33 12 PM

Dependencies:

  • react-native-modalize 2.1.0
  • react-native 0.65.1
  • react-native-gesture-handler 1.10.3
LongVT8 commented

Please, fix issue on iPhone 14 :(

harrigee commented

I have this issue as well on my iPhone 14 Pro Device with iOS 16.1. Oddly my Simulator with the same setup renders it correctly.

kg-currenxie commented

Same here. Both simulator and real device. Thought rn-device-info would fix it :/

devym-37 commented

@harrigee @brianedelman @kg-currenxie @LongVT8
I pushed the corrected commit and deployed the update as an npm module after forking, just in case
https://www.npmjs.com/package/react-native-patch-modalize

  • 👍1
akruczek commented

Any updates? I have this issue as well on iPhone 14 and now also iPhone 15.

devym-37 commented

@akruczek I pushed the corrected commit and deployed the update as an npm module after forking, just in case
https://www.npmjs.com/package/react-native-patch-modalize