jeremyckahn/shifty

this._reject is not a function

kurtextrem opened this issue · 4 comments

kurtextrem commented

While trying out your solution: #107 (comment)

I've encountered the following error:
Uncaught TypeError: this._reject is not a function shifty:2
at t.value (shifty.js:2)

it happens when calling .stop(false) on an existing tweening instance (created with new Tweenable)

(same happens when I call .stop(true), but with the error this._resolve is not a function)

kurtextrem commented

So this happens when setConfig hasn't been called yet. Not sure if still an issue then. Feel free to close if you don't think it is.

jeremyckahn commented

Hi @kurtextrem, I'd be curious to know what code is causing this error to occur. I can only see this happening if a new tween was started with no parameters and then.stop() was called. Assuming that's what's causing this, what is the use case for starting a tween without parameters?

kurtextrem commented

No use case, it simply happened - so as I said feel free to close (in case you don't want to add a warning or so)

jeremyckahn commented

Understood. It sounds like the API was not being used as intended, so I would prefer to make no change at this time. I am open to PRs to change the error handling, though!

I will close this for now. Thanks for reporting this issue, though!