jeroen/V8

./configure: 8: ./get-v8-linux.sh: Syntax error: redirection unexpected

pachadotdev opened this issue · 6 comments

pachadotdev commented

v 4.2.2. from CRAN fails on Ubuntu 20.04

jeroen commented

Thanks fixed now.

pachadotdev commented

I meant: it can't be installed on Ubuntu 20.04 (i.e., on my laptop)

jeroen commented

There was a temporary problem bit it should be fixed now.

If you still have a problem and want me to help, please post the full install log .

alexconrey commented

Can we have some more information around the cause of the error? It seems like the logic used in this repo relies on the master branch and has no correlation to versioned releases.

alexconrey commented

edit: updated to reflect that the script does actually live somewhere, it's just in github pages instead of the tracked version branches.

It appears that the get-v8-linux.sh script referenced by the configure file changed from when I downloaded it yesterday:

alex@computer ~ % diff ~/Downloads/get-v8-linux.sh ~/Downloads/get-v8-linux\ \(1\).sh
8,9c8,9
< if grep -Fq "clang++" <<<"$CXX"; then
< if printf "#include <string>\n#ifndef _LIBCPP_VERSION\n#error not libcxx\n#endif" | $CXX -E -xc++ - > /dev/null 2>&1; then
---
> if echo "$CXX" | grep -Fq "clang"; then
> if printf "#include <string>\n#ifndef _LIBCPP_VERSION\n#error not libcxx\n#endif" | $CXX -E -xc++ - >/dev/null 2>&1; then

https://github.com/jeroen/V8/blob/master/configure#L88

This is calling a script that is only in the github pages branch and is not rooted to any specific version: http://jeroen.github.io/V8/get-v8-linux.sh

This is also problematic for users who wish to ensure dependencies are not compromised or otherwise tainted by pinning dependency versions. This really should be checked into versioned branches, both for audit/security purposes but also for pinning known good builds. We will need to pin to a revision if the trend of pushing directly to master is one this repo is going to continue following.

Can you please do one of the following?

jeroen commented

You can set DISABLE_STATIC_LIBV8 at install time and link to libv8-dev on ubuntu if you prefer that.

  • 👍1