Add extra e2e test that exercises some other features
jeroenheijmans opened this issue · 1 comments
jeroenheijmans commented
The current basic e2e test just boots up the app. The happy-path-flow e2e test will log the user in and out via the login button. This leaves a few components unused in e2e tests:
- The
auth-guard.service.ts
(so being prevented from going to a protected page) - The
auth-guard-with-forced-login.service.ts
(so getting sent off to IDS4 when you go to a protected page) - The
should-login.component.ts
page - and maybe a handful of others too
Let's add 1 more e2e test that tests an extra typical "flow" exercising the above parts.
Note that npm run e2e
should run the tests, and these are also run for a PR via GitHub Actions (and nightly for master
).
jeroenheijmans commented
It would still be a nice (albeit low-prio) addition to have this, but I've removed hacktoberfest since the repo won't participate in the event per-say.