jeroenrinzema/commander

infinit lock

NOMORECOFFEE opened this issue · 1 comments

Describe the bug
forget to call wg.Done() and if we call Close() then we are lock on wg.Wait()
https://github.com/jeroenrinzema/commander/blob/master/dialects/kafka/consumer/group.go#L94
https://github.com/jeroenrinzema/commander/blob/master/dialects/kafka/consumer/group.go#L89

To Reproduce
Steps to reproduce the behavior. Please include code examples:

  1. Setup '...'
  2. Emit event '....'
  3. Await x seconds '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

  • OS: [e.g. Linux]
  • Golang version

Additional context
Add any other context about the problem here.

Hi, thank you very much for reporting this race condition.