Use generic key-val store
Opened this issue · 2 comments
Hi,
I am using this crate now and I think it performs really well. However, I am using it in a concurrent server, and I currently have to wrap in Arc<RwLock<..>>. It would be great if it was possible to plug in dashmap to make the LRU thread-safe. The best would be if it would be generic over key-value store, then even remote stores could be used. This would probably involve implementing a K-V trait for a few selected collections, or newtype for users who wish to use un-implemented external structures. What do you think?
Related to #21
Hi @gauteh! I like this idea, but I think it may be tricky to implement because the cache uses both a hashmap and a linked list internally. So while it may be fairly straightforward to swap out the current hashmap with dashmap, converting the linked list to support concurrent operations will likely be more difficult because it's implemented by hand. And then, even if both the hashmap and linked list supported concurrent operations, we would still have to ensure that their composition also supported concurrent operations correctly as well. With that being said, I'm certainly not opposed to the idea, it's just that I think it would take a good chunk of work and I'm not sure I'd be able to devote the necessary amount of time to it. I'd love to be proven wrong though if you have different thoughts on how to approach this?
For the reference, at near we are using Arc<Mutex> as well, wrapped into this data structure:
https://github.com/near/nearcore/blob/master/utils/near-cache/src/sync.rs