jeromegn/Backbone.localStorage

Signatures for success() and error() not (model, resp, options)

Closed this issue · 0 comments

The function signatures for success() and error() seem intentionally wrong.
When I look at the code for Backbone.sync() in Backbone.VERSION = '1.2.3' I see that the success() and error() functions should accept parameters (model, resp, options). In the documentation at backbonejs.org, there are several mentions that confirm this; while allowing also for (collection, response, options). Yet, in "backbone.localStorage.js", this signature is striktly limited to Backbone.VERSION==="0.9.10". Interestingly, this (bad) code is exactly what is found in the discussion of "Issue #73", under "Krivega commented on Feb 19, 2013" -- did that person sneak his code into the main distribution? Anyway, it would seem the 3 parameter option should be called for any modern versions of Backbone, not just "0.9.10".