jessesquires/PresenterKit

UIImage support for UIBarButtonItem for DismissButtonConfig

psartzetakis opened this issue · 6 comments

psartzetakis commented

Hi, 😀
I was thinking that it might be a good feature if there was a way to set an image for the UIBarButtonItem through the DismissButtonConfig.
What do you think ? 🤔

jessesquires commented

Seems reasonable 👍

We could add a .image(UIImage) case to the Text enum:
https://github.com/jessesquires/PresenterKit/blob/develop/Source/DismissButtonConfig.swift#L70-L77

We should probably rename it from Text to something else... 🤔

jessesquires commented

Renaming enum Text would be a breaking change though 😢

psartzetakis commented

Would you recommend a different approach in order to avoid renaming enum Text ?

jessesquires commented

@psartzetakis - Hm... probably not. I can't really thing of a better way to do this.

It's not a big deal. 😄

However, it would be nice include more changes for the 4.0 release.

  • 👍1
psartzetakis commented

However, it would be nice include more changes for the 4.0 release.

@jessesquires I have a couple of ideas..🤔.
However I believe it would be better to open separate issues so we can discuss them separately.. 😀

  • 🎉1
jessesquires commented

However I believe it would be better to open separate issues so we can discuss them separately..

Definitely! 💯 👍