Finish CI setup
Closed this issue · 6 comments
Keep using GitHub actions or switch to TravisCI?
Not sure if GH Actions can do everything we need. Maybe use both?
ToDo:
- get bundle install working (GH actions) (#14)
- run swiftlint on PRs (action)
- setup and run danger (action)
- run
pod lib lint(#14) - test SPM (#16)
Notes:
- If switching to Travis CI, setup like this.
- other GitHub actions to consider
GH now using macOS 10.15:
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners#macos-1015
Example:
https://github.com/plangrid/ReactiveLists/blob/master/.github/workflows/ci.yml
Re: Run swiftlint on PRs, just put up this example in another repo: https://github.com/anayini/ANReactiveTableKit/pull/7/files.
Can make an equivalent one here in a bit
Also as a headsup, I'm going to the Github conference next week and can ask any particular questions you have.
swiftlint - 👍 sounds good
conf - not sure about specific questions, but generally would like to see feature parity with Travis-CI. seems like there might be some gaps.
will travis and codecov work on GH CI?
Update here re: Travis - I'm in the process of trying to migrate all of CI for ReactiveLists over to GitHub Actions. So far I've got everything besides CodeCov and Danger. Danger should be easy, I'll have to look into CodeCov. I'm noticing significantly faster builds on GitHub Actions CI (4-5x faster than Travis)
Nice 👍
You know, it should be possible to use both GH-Actions and TravisCI.
We could run only Danger and codecov on TravisCI, which sounds like it would still be faster.