jest-community/jest-extended

asymmetric matcher type definitions are not good (yet again)

hugebdu opened this issue · 18 comments

hugebdu commented

After the recent change, cannot be used as nested in jest.
See this comment.

SimenB commented

PR welcome to fix it 👍

hugebdu commented

@SimenB I'm not familiar with vitest and it's typings.
however this PR broke jest typings.

I could PR with a revert :)

rluvaton commented

Sorry 😬

Could you create a repro repo so I could take a look at it later today and fix it

rluvaton commented

I don't know how the current AsymmetricMatchers types works

As you can see in:

https://github.com/facebook/jest/blob/9af2540f87e8e0d4f1e0528981529ad1bc30a28a/packages/expect/src/types.ts#L114

The return type is AsymmetricMatcher and we return void (even before my change)

hugebdu commented

Could you create a repro repo so I could take a look at it later today and fix it

wil do
10x

rluvaton commented

@hugebdu could you please check if #551 working for you? it fixed it for me...

@SimenB Could you please review the PR 😄

hugebdu commented

@rluvaton negative. now I have

  ● Test suite failed to run

    test.spec.ts:17:7 - error TS2322: Type 'AsymmetricMatcher' is not assignable to type 'number'.

    17       baz: expect.toBeNumber()
             ~~~

      test.spec.ts:5:3
        5   baz?: number;
            ~~~
        The expected type comes from property 'baz' which is declared here on type 'Foo'
hugebdu commented

@rluvaton built-in asymmetric matchers (like expect.stringContaining) have any as return type

rluvaton commented

@rluvaton built-in asymmetric matchers (like expect.stringContaining) have any as return type

Where do you see that?

https://github.com/facebook/jest/blob/9af2540f87e8e0d4f1e0528981529ad1bc30a28a/packages/expect/src/types.ts#L119

rluvaton commented

change to any, could you please retry?

SimenB commented

My guess is that they're any in @types/jest

hugebdu commented

@rluvaton

change to any, could you please retry?

perfection 👍

rluvaton commented

thanks, so it's ready for review 😄

  • 🎉1
hugebdu commented

@SimenB @rluvaton
Thank you guys

  • 👍1