jethrokuan/fzf

Can't use Ctrl-o and Ctrl-g bindings

Tumetsu opened this issue · 2 comments

Hello, I have fish 2.7.1 and fzf 0.17.5.

After installing this plugin with omf, it looks like the Ctrl-o and Ctrl-g bindings do not work. Ctrl-t and Ctrl-r and Alt bindings do work as explained in the readme. Why?

I'm not really experienced in fish scripting or how omf/fisher etc. work but I checked the ~/.config/fish/functions/fzf_keybindings.fish and found the following lines which seem to bind some of the functions:

  bind \ct fzf-file-widget
  bind \cr fzf-history-widget
  bind \ec fzf-cd-widget

  if bind -M insert > /dev/null 2>&1
    bind -M insert \ct fzf-file-widget
    bind -M insert \cr fzf-history-widget
    bind -M insert \ec fzf-cd-widget
  end

Why there isn't bindings defined for the opening the file with Ctrl-o or Ctrl-g? And if this is intentional how do I define them myself? Pardon me if I missed something obvious about the usage of this plugin :)

P.S: I also tried this on two computers and terminals and it looks like Ctrl-o or Ctrl-g should not be intercepted by anything else.

Looks like I missed this in your read me:

Note that the fzf utility has its own out-of-the-box fish package. What sets this package apart is that it has a couple more integrations, most notably tab completion, and will probably be updated more frequently. They are not compatible so either use one or the other.

However, if I remove the ~/.config/fish/functions/fzf_keybindings.fish file, I'll get errors. So how do I activate this plugin properly?

Errors:

fish: 
fzf_key_bindings
^
in function “__original_fish_user_key_bindings”
	called on line 45 of file ~/.local/share/omf/init.fish

in function “fish_user_key_bindings”
	called on standard input

in function “__fish_reload_key_bindings”
	called on line 236 of file /usr/share/fish/functions/__fish_config_interactive.fish

in function “__fish_config_interactive”
	called on line 216 of file /usr/share/fish/config.fish

in function “__fish_on_interactive”
	called on standard input

in event handler: handler for generic event “fish_prompt”

Resolved. I had to install this plugin with Fisher to get all key bindings to work and install the fzf without key bindings.