jetstack/navigator

Pilot init container resource limits

cehoffman opened this issue · 3 comments

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Init containers to install the pilot into the database container should have resource limits specified too to operate inside of quota enforced namespaces.

In wallrj@bed5173#r28074128 @cehoffman wrote:

This is only enforcing that requests are set. We have quota set to have caps on limits as well. https://kubernetes.io/docs/concepts/policy/resource-quotas/

Thanks Chris, so we need to add limits and requests on the Init container. Sorry I missed that. I was concentrating only on allowing configuration of main pod resources.
I'll try and test and fix that tomorrow.

/reopen

@wallrj: The reopen prow plugin is deprecated, please migrate to the lifecycle plugin before April 2018

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.