jfilter/clean-text

Improve scikit-learn compatibility

CarloLepelaars opened this issue · 0 comments

CarloLepelaars commented

Thank you for building and open-sourcing this!

Unfortunately there are still some compatbility issues in CleanTransformer, especially when using it within Pipeline and FeatureUnion objects.

  1. y argument missing in fit.
  2. Missing partial_fit method.
  3. Missing get_feature_names_out method.

I implemented these in #31. Would be happy to discuss any changes or additional functionality + tests.