Konacha 3.1.0 includes bug in chai 1.9 for include/contain assertions
Closed this issue · 8 comments
Just to inform anyone who wants to update to Konacha 3.1.0: the inclusion of chai 1.9 causes bugs in include assertions (checks if an Array / Object contains some value).
The chai people are already aware of this, see issue on chai repository: chaijs/chai#239
Yeah, feel free to update our chai submodule when a point release comes out and ping me for a release.
Sure, I subscribed to the chai issue linked above, but unfortunately, none of their proposed solutions made it into master yet, so we'll have to wait for a bit.
@jfirebaugh Just updated the chai submodule to 1.9.1 on master, but I'm now looking at 5513440 and see there that I should update the embedded chai.js as well. I'm not sure how to update embedded code in vendor/assets/javascripts/chai.js... Any suggestions on procedure for this?
rake assets:copy will do that for you.
Ok great! Just committed to master. Just let me know once you release a new version and I'll close this issue.
Awesome, thanks. One thing I noticed from the chai release notes -- the README needs an update where it uses chai.Assertion.includeStack. Can you take care of that?
Just pushed the update. To be sure: I could only find one instance of chai.Assertion in the README.md.
Thanks, that was it. I just release 3.2.1.