jfromaniello/selfsigned

v1.3.0 is a breaking change via node-forge upgrade in node < 10: "ReferenceError: URLSearchParams is not defined"

billneff79 opened this issue · 5 comments

billneff79 commented

If you are running node < 10, the upgrade to node-forge 1.x contained in selfsigned@1.3.0 produces the following error because URLSearchParams is not natively supported:

/Users/bneff/repos/blocks/node_modules/selfsigned/node_modules/node-forge/lib/log.js:305
    query = new URLSearchParams();
    ^

ReferenceError: URLSearchParams is not defined
    at Object.<anonymous> (/Users/bneff/repos/blocks/node_modules/selfsigned/node_modules/node-forge/lib/log.js:305:5)
    at Module._compile (internal/modules/cjs/loader.js:654:30)

Upgrading node-forge to 1.x should have been a major change in selfsigned

devmubeen commented

Anyone checked this issue?

reachmehere89 commented

Same issue

ahmedHusseinF commented

Same issue, i think you should upgrade the major version not just a patch, because this is a breaking change in node-forge

jfromaniello commented

😫 my bad, ok I will publish a major version and a patch reverting the patch. Does that sounds good?

  • 👍2
  • 🚀1
jfromaniello commented

ok, now I published:

  • selfsigned@2.0.0 (with engines node >=10) using node-forge@^1.2
  • selfsigned@1.10.14 which is the same than selfsigned@1.10.12
  • 🎉1