Error in architecture detection under Windows Server 2008 Standard
Closed this issue · 5 comments
At node_modules\winser\bin\winser:87
, I need to change the regular expression from
var architecture = stdout.match(/([2346]{2})\-Bit/)[1];
to
var architecture = stdout.match(/([2346]{2})\-[bB]it/)[1];
since Windows Server 2008 return "64-bit" instead of "64-Bit".
I think we should use this
@dignifiedquire do you remember why you used wmic OS get OSArchitecture
instead of node.js process.arch
?
The problem is that the process architecture can differ from the os architecture which is what we really want to know. E.g. node 32bit would give 32bit process.arch even if it's running on a 64bit machine. os.arch should solve that but doesn't right now see this issue nodejs/node-v0.x-archive#2862
On Wed, Apr 17, 2013 at 1:42 PM, José F. Romaniello
notifications@github.com wrote:
@dignifiedquire do you remember why you used
wmic OS get OSArchitecture
instead of node.jsprocess.arch
?Reply to this email directly or view it on GitHub:
#12 (comment)
thanks @dignifiedquire it makes sense,
@eddie168 fixed in 0.1.2
Thanks for the quick fix!