jgabaut/helapordo

[BUG] 1.2.5 fails WIN32 build

Closed this issue · 1 comments

Describe the bug
With version 1.2.5, koliseo was bumped to 0.3.3 from 0.3.0, but the gameloop_Win() function was not updated to remove mentions of KOLISEO_DEBUG and KOLISEO_DEBUG_FP. Hence, the build fails when trying to build with mingw32.

To Reproduce
Steps to reproduce the behavior:

  1. git checkout 1.2.5
  2. ./configure --host x86_64-w64-mingw32
  3. make rebuild
  4. Build fails with:
src/helapordo.c: In function ‘gameloop_Win’:
src/helapordo.c:12203:25: error: ‘KOLISEO_DEBUG’ undeclared (first use in this function); did you mean ‘SO_DEBUG’?
12203 |                         KOLISEO_DEBUG = 1;
      |                         ^~~~~~~~~~~~~
      |                         SO_DEBUG
src/helapordo.c:12203:25: note: each undeclared identifier is reported only once for each function it appears in
src/helapordo.c:12221:33: error: ‘KOLISEO_DEBUG_FP’ undeclared (first use in this function)
12221 |                                 KOLISEO_DEBUG_FP = fopen(path_to_kls_debug_file,"w");

Expected behavior
Working build.

Desktop

  • OS: Windows
  • Version: 1.2.5

Additional context

koliseo dropped KOLISEO_DEBUG and KOLISEO_DEBUG_FP globals with version 0.3.1.

Fixed in #38, version 1.2.6.