[BUG] Game hang for left, right key press on saveslot pick
Closed this issue · 5 comments
Describe the bug
After initial game start on screen that says, Select your save slot
pressing invalid keys hangs the game. No keys work except sending a kill signal to the process by Ctrl-c
To Reproduce
Steps to reproduce the behavior:
- ./helapordo -D
- Press enter to start
- Press enter again to start a new game
- Press left arrow key (or alternatively, press left/right key after pressing up/down keys)
- Yes, now enter or up/down arrow wouldn't work. (I also tried
Esc
orq
orm
nothing works)
Expected behavior
Game should discard bad/invalid keys
Screenshots
Comment if you want a screenshot. Didn't found it necessary.
Desktop (please complete the following information):
- OS: ArchLinux
- Version: 1.4.7
Additional context
None
Is this for 1.4.7
? You did not specify a version. If you caught this on devel branch, please say so.
I tested it with master branch (main branch of this repository).
I didn't specify version anywhere so it must be latest (not sure).
I compiled the source and tested, so version must be latest right?
This issue is also present in devel branch. I tested devel branch to confirm it.
I didn't specify version anywhere so it must be latest
In top post it said "e.g. Latest" which is verbatim the template, without even dropping the "e.g.". Plus, if in the future I look at this issue, there's no clear indication of what "latest" means.
This issue is also present in devel branch. I tested devel branch to confirm it.
That's ok, I prefer for it to be on master
so that it means the culprit is before the current developments (smaller, older surface area).
Found the culprit and fixed on devel
: commit
This has been in the code ever since the first introduction of saveslot selection, back in 1.0.11
.
- Version:
>=1.0.11
In top post it said "e.g. Latest"
Oh.. i thought i had to put the OS version. As this was asked under Desktop
related heading.
I will fix the version there.
In top post it said "e.g. Latest"
Oh.. i thought i had to put the OS version. As this was asked under
Desktop
related heading. I will fix the version there.
You are absolutely right, I should definitely clarify the issue template. Sorry!