jgm/commonmark-hs

Attributes extension regression in commonmark-extensions 0.2.3.3

Closed this issue · 4 comments

srid commented

Upstream issue: srid/emanote#372

Repro

The particular trigger seems to be the {.timeline} part in the source:

image

This renders as:

image

0.2.3.3

Once I go back to commonmark-extensions version 0.2.3.2 this problem goes away, thus suggesting that the culprit must be in the only change here: db528aa (done for #96).

jgm commented

I just compiled the latest source and ran the commonmark executable on

## Timeline queries

Queries can be rendered as a timeline by using the `timeline` code block attribute.

~~~markdown
```query {.timeline}
tag:blog/ema
```
~~~

Result was


```
<h2>Timeline queries</h2>
<p>Queries can be rendered as a timeline by using the <code>timeline</code> code block attribute.</p>
<pre><code class="language-markdown">```query {.timeline}
tag:blog/ema
```
</code></pre>

which looks right. So I haven't been able to reproduce this.

srid commented

It could be the extension order that is triggering it? I'll try to find come up with a minimal independent repro.

This was fixed by 10f7b0c.

jgm commented

Good to know, will close now.