jgraph/drawio-nextcloud

Failed deletion bug persists after update

Cl00e9ment opened this issue a year ago · 10 comments

Cl00e9ment commented a year ago

Bug

The logs are spammed with the following message:

OCP\Files\NotFoundException: /appdata_XXXX/drawio/previews

Existing (closed) reports

The fix apparently did not work

The bug is still happening, supposedly because the fix is not merged yet. See #40 (comment)

However, I'm using the latest version (2.1.1), and the fix is present since 2.1.0. See https://github.com/jgraph/drawio-nextcloud/blob/v2.1.0/lib/Listeners/FileDeleteListener.php#L41

Cl00e9ment commented a year ago

The exception is thrown on line 39, so there should probably be another verification to check that the directory exists. Or directly check for the existence of the file, without creating the directory object.

m-mohamedin commented a year ago

Thanks for the report.
It will be fixed in the next release

👍1

lopez-damiano commented a year ago

Thanks for the report. It will be fixed in the next release

Thanks !