Not all functions are available when searching in the function details visualizer
GoogleCodeExporter opened this issue · 6 comments
GoogleCodeExporter commented
The title says it all really.
I think the list of results used when searching for a function in the function
details visualizer is cropped(to around 200 functions?) and so even if I enter
the name of a heavily called function it is not displayed if it was called
after a certain execution time(I think, might have been based on thread as the
game logic thread takes a while to start...).
If it has to be cropped, then it would be much better to crop based on the
amount of time in the function(inc children). Also 200 is a very low number for
a non trivial app in any case.
Original issue reported on code.google.com by dbl...@fastmail.fm
on 16 Jul 2010 at 3:48
GoogleCodeExporter commented
Hm. The list is cropped at 250, but the point is mostly that you're supposed to
search for a specific function. I've also had some trouble settling on a
criteria for what should come up without a search.
In any case, this is happening with the SVN version? I'm mainly curious whether
the glitch is the visualizer or whether the function is flat out not in the
database. The underlying data code for that visualizer got a total rewrite and
I'm wondering if I screwed it up.
Original comment by promit....@gmail.com
on 17 Jul 2010 at 12:17
GoogleCodeExporter commented
No, this is with a search. The functions are in the database, at least
partially since they are shown in the other visualizers.
The version I am using has not been updated since my last commit, so it doesnt
include your recent changes(I was waiting for thing to stabalize before
updating:-).
I would be interested to know why you think you need to crop the list of
functions? Listviews should be able to handle 10 000s of entries without
problems if used correctly. (Perhaps this would require some sort of
virtualization though).
Original comment by dbl...@fastmail.fm
on 17 Jul 2010 at 11:56
GoogleCodeExporter commented
Having a gigantic list of every function in the app didn't seem very useful, so
I clamped it to an arbitrary number. I could use a larger arbitrary number? Or
do you really want a list of thousands of functions? I need to mess with how
the sort is handled as well.
Original comment by promit....@gmail.com
on 17 Jul 2010 at 1:54
GoogleCodeExporter commented
Well it isnt really that important, but I would have gone with a gigantic list
sorted by name. That way I can browse through the namespaces by scrolling down
the list.
The real problem is functions not showing up when searching.
Original comment by dbl...@fastmail.fm
on 17 Jul 2010 at 2:49
GoogleCodeExporter commented
Yeah I'm not too sure about that -- I just ask the database via LIKE %keyword%.
But the visualizer's data code just got rewritten anyway.
I'll see what's most effective to do with the function list. Maybe the thing to
do is to strip out "uninteresting" functions when there's no search text and
report the entire rest of the set.
Original comment by promit....@gmail.com
on 17 Jul 2010 at 2:53
GoogleCodeExporter commented
Closing this for the time being, but wouldn't mind revisiting past 3.1 (soon).
Original comment by promit....@gmail.com
on 8 Mar 2011 at 5:29
- Changed state: WontFix