jgroups-extras/jgroups-kubernetes

Labels system property name inconsistence

mshaposhnik opened this issue · 2 comments

mshaposhnik commented

As far as i can see in code, labels filtering property name is
KUBERNETES_LABELS
(https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/src/main/java/org/jgroups/protocols/kubernetes/KUBE_PING.java#L81)
But in readme, it is 2 times mentioned as KUBERNETES_LABEL.

is that a bug or am I missing something? I can prepare readme fixup PR if you wish.

slaskawi commented

Thanks for spotting this @mshaposhnik !

Yes, it would be great if you could prepare a Pull Request with a fix. Please remember about backwards compatibility (even though it was an obvious typo, old deployments should work with it) and documentation update.

belaban commented

I fixed this in the readme, thx,

  • 👍1