Sorting (sort-fn) function does not work
Closed this issue · 7 comments
When I took a custom sort function and passed it to consult-org-roam-node-read
, it didn't work.
I'm not an expert in this, but it looks like consult package somehow affects it.
After reading consult's docs, about consult--read in particular, I changed the value of :sort
to nil
consult-org-roam/consult-org-roam.el
Line 157 in 2e6427a
Hi @cuprum,
thanks for your message. Can you give an MWE here?
Did you passt a sort-fn
when calling consult-org-roam-node-read
?
I am asking since org-roam-node-read
is overriden here via advice-add
.
Best regards,
jgru
Here is https://gist.github.com/cuprum/20af58bc1f09460e552baf4726662c4f from my init.el.
I use this code to preview my daily notes strickly reverse alphabetically.
Hi @cuprum,
Here is https://gist.github.com/cuprum/20af58bc1f09460e552baf4726662c4f from my init.el. I use this code to preview my daily notes strickly reverse alphabetically.
thanks for sending this snippet. Could you clarify why setting sort-fn
to nil
works?
I am asking because you pass your custom sort function in your snippet here, and this should then never be used as far as I see. Can you clarify this for me?
Best regards,
jgru
Can you clarify this for me?
I'm use bundling of Vertico + Marginalia + Orderless + Consult. So, the preceding code does not work without :sort nil
in consult-org-roam.el. More precisely, in minibuffer with :sort sort-fn
still show mtime's sorting order for my daily notes when i call yr/orm-node-find-wrapper
.
Can you clarify this for me?
I'm use bundling of Vertico + Marginalia + Orderless + Consult. So, the preceding code does not work without
:sort nil
in consult-org-roam.el. More precisely, in minibuffer with:sort sort-fn
still show mtime's sorting order for my daily notes when i callyr/orm-node-find-wrapper
.
Okay, thanks. Probably, this goes back to passing the parameter sort-fn
already to org-roam-node-read--completions
Would you mind to test your specific use case whether supplying nil
to this func(org-roam-node-read--completions
) and your sort-fn
to consult-read
?
Best regards,
jgru
Would you mind to test your specific use case whether supplying
nil
to this func(org-roam-node-read--completions
) and yoursort-fn
toconsult-read
?
With the specified conditions, I see the mtime's order.
In any case, Org-roam is responsible for sorting (more precisely, org-roam-node-read--completions
in this case). Apparently, one should not use :sort sort-fn
additionally. Moreover, docs for consult--read
says
SORT should be set to nil if the candidates are already sorted.