jgthms/minireset.css

iframe height auto

luwes opened this issue · 5 comments

luwes commented

Not 100% sure it's an issue but when I upgraded Bulma some of the social iframe buttons had too big of an height. See screenshot. If the height: auto is toggled off the Github button returned to its normal height.

screen shot 2019-02-10 at 8 24 54 am

Link: https://swiss-element.netlify.com/

cve commented

How did you fixed it? I have the same problem with embeded Youtube video iframe.

Hi,

I've problems with ads which are displayed within an iframe. The iframe is only taking about one-third of the height it should, so the ad is not displayed fully.

The reason is the mini reset of the iframe to height auto

I've added

.my-ad-container iframe
{
height: 100%;
}

to avoid the problem.

Best wishes,
Georg.

This caused me so much grief as I just spent 6 hours tracing it down to this issue. I'm glad this horrible line of CSS has been removed in 0.0.5.

@tjkohli Im on the latest Bulma version 0.7.5 and the line has not been removed. I don't have a working solution to this.

I'm wondering why this line is in there. It's not actually a part of reset.css originally.